Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: non-native refresher breaks scrolling #27601

Closed
3 tasks done
mrahn24 opened this issue Jun 6, 2023 · 6 comments · Fixed by #27602 · May be fixed by nachodev-ui/We-Take-U#108
Closed
3 tasks done

bug: non-native refresher breaks scrolling #27601

mrahn24 opened this issue Jun 6, 2023 · 6 comments · Fixed by #27602 · May be fixed by nachodev-ui/We-Take-U#108
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@mrahn24
Copy link
Contributor

mrahn24 commented Jun 6, 2023 •
edited
Loading

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

When using a non-native refresher, moving the view (refresher) slightly down, back to the top of the view (deltaY <= 0) and down again in one move (one tap and hold) breaks the scrolling of the view. See attached video for a better understanding.

2023-06-06-bug-refresher-breaks-scrolling.mov

Expected Behavior

View scrolling does not break when using the refresher.

Steps to Reproduce

  1. Checkout the sample application: https://github.com/mrahn24/ionic-bug-examples -> Branch: bug/r and run it
  2. Tap and hold to use the refresher
  3. Move down (do not move over pullMax)
  4. Move up to the top of the view (deltaY <= 0)
  5. Move down (do not move over pullMax)
  6. Release tap and hold
  7. Try to scroll down -> Scroll should be broken

Code Reproduction URL

https://github.com/mrahn24/ionic-bug-examples/tree/bug/refresher-breaks-scrolling

Ionic Info

Ionic:

Ionic CLI : 6.20.1 (/Users/mrahn/.config/yarn/global/node_modules/@ionic/cli)
Ionic Framework : not installed
@angular-devkit/build-angular : 16.0.4
@angular-devkit/schematics : 15.2.8
@angular/cli : 16.0.4
@ionic/angular-toolkit : 9.0.0

Capacitor:

Capacitor CLI : 5.0.4
@capacitor/android : not installed
@capacitor/core : 5.0.4
@capacitor/ios : not installed

Utility:

cordova-res (update available: 0.15.4) : 0.15.1
native-run : 1.7.2

System:

NodeJS : v18.15.0 (/Users/mrahn/.n/bin/node)
npm : 9.5.0
OS : macOS

Additional Information

Bug introduced with #26613
@ionitron-bot ionitron-bot bot added the triage label Jun 6, 2023
@mrahn24 mrahn24 mentioned this issue Jun 6, 2023
Merged
2 tasks
@liamdebeasi liamdebeasi self-assigned this Jun 6, 2023
@liamdebeasi
Copy link
Contributor

Thanks for the report! I am able to reproduce this issue. I will take a look at your PR shortly.

@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Jun 6, 2023
@ionitron-bot ionitron-bot bot removed triage labels Jun 6, 2023
@liamdebeasi liamdebeasi mentioned this issue Jun 6, 2023
Closed
2 tasks
@liamdebeasi
Copy link
Contributor

liamdebeasi commented Jun 6, 2023 •
edited
Loading

Here is a dev build with a potential fix if you are interested in testing:

npm install @ionic/[email protected]

@mrahn24
Copy link
Contributor Author

mrahn24 commented Jun 7, 2023

The dev build works like a charm. Thank you very much @liamdebeasi ! 🙏

@liamdebeasi liamdebeasi removed their assignment Jun 7, 2023
liamdebeasi added a commit that referenced this issue Jun 7, 2023
@mrahn24 @liamdebeasi
fix(refresher): scroll styles are reset when using non-native refresh…
92c5545 
…er (#27602)

Issue number: resolves #27601 

---------

## What is the current behavior?
The current behavior restores overflow styles while moving (within the
setCSS function).

## What is the new behavior?
Overflow styles are restored when refresher gesture ends.

## Does this introduce a breaking change?
- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
Honestly, I don't know exactly. From code perspective I would say 'Yes',
but I can't get the impact of the change.

Ionic Team edit: There are no changes to the public API, and this is
fixing a behavior that used to work so there are no breaking changes.

## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: Liam DeBeasi <[email protected]>
@liamdebeasi
Copy link
Contributor

Thanks again for the report and the PR! This fix will be in the next release of Ionic v7. We also plan to backport this to Ionic v6 since it was introduced in that major release.

liamdebeasi added a commit that referenced this issue Jun 7, 2023
@mrahn24 @liamdebeasi
fix(refresher): scroll styles are reset when using non-native refresh…
e409c3f 
…er (#27602)

Issue number: resolves #27601 

---------

## What is the current behavior?
The current behavior restores overflow styles while moving (within the
setCSS function).

## What is the new behavior?
Overflow styles are restored when refresher gesture ends.

## Does this introduce a breaking change?
- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->
Honestly, I don't know exactly. From code perspective I would say 'Yes',
but I can't get the impact of the change.

Ionic Team edit: There are no changes to the public API, and this is
fixing a behavior that used to work so there are no breaking changes.

## Other information
<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

---------

Co-authored-by: Liam DeBeasi <[email protected]>
@liamdebeasi liamdebeasi mentioned this issue Jun 7, 2023
Merged
liamdebeasi added a commit that referenced this issue Jun 8, 2023
@liamdebeasi @mrahn24
fix(refresher): scroll styles are reset when using non-native refresh…
3f5e893 
…er (#27619)

resolves #27601 

Co-authored-by: Michael Rahn <[email protected]>
@liamdebeasi
Copy link
Contributor

This fix was released today as part of the v6.7.5 and v7.0.12 releases.

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 8, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
2 participants
@liamdebeasi @mrahn24