Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make loom a dev-dependency #118

Open
stefnotch opened this issue Sep 6, 2024 · 1 comment
Open

Make loom a dev-dependency #118

stefnotch opened this issue Sep 6, 2024 · 1 comment

Comments

@stefnotch
Copy link

Loom is currently only being used as a dependency for tests, as far as I can tell. However, it is included using [target.'cfg(loom)'.dependencies.loom].
This comes with a few issues, mainly

  • cargo vendor vendors dependencies of loom.
  • Dependencies of loom are included in Cargo.lock when using a crate that depends on loom.
  • cargo audit includes dependencies of loom when using a crate that depends on loom.

The workaround for these problems is to make loom an optional dependency: crossbeam-rs/crossbeam#666
from > > * cargo vendor vendors dependencies of loom.

  • Dependencies of loom are included in Cargo.lock when using a crate that depends on loom.
  • cargo audit includes dependencies of loom when using a crate that depends on loom.

The workaround for these problems is to make loom an optional dependency: crossbeam-rs/crossbeam#666

Could this be improved? Either by making loom an optional dependency, or by moving it to dev-dependencies. Currently this is an issue for me.

@nagisa
Copy link
Owner

nagisa commented Sep 23, 2024

It can't become a dev-dependency unfortunately because integration of loom requires changes to the library code. It could possibly become an optional dependency, though I do not currently have capacity to work on this in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants