-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnimatePresence + Hermes doesn't work #214
Comments
Interesting, so this works without Hermes for you? What version of Hermes? |
And you're saying that this only happens with Moti 0.18, but not 0.17? |
Expected behavior video recorded without enabling hermes. |
Yeah, on 0.17.1 it works as expected. |
I see. It looks like this would be caused by the Framer Motion upgrade in Could you try adding this to your {
"resolutions": { "framer-motion": "3.9.1" }
} And then run |
Didn't help :( |
🧐 i can’t see anything else in the change log that would be unique to 0.18 causing problems…what’s the full code? |
|
Having the same issue on Android (not iOS) on moti 0.18 |
@faz919 and disabling hermes solves it? |
Not sure but downgrading to moti 0.17.1 fixed the issue. |
did you try the yarn resolution? |
nah. Was in a time crunch and had to do fastest possible solution |
@nandorojo hi, any news? |
@nandorojo Resolution doesn't seem to be working.
Another issue that I have is that Seems to work properly on lower versions. So for now I'm downgrading to Edit:
|
Thanks for the update. I'll keep looking into it soon when I have some time. I'm convinced it's a dependency-related issue. |
Also to add, using sequences with the For example, the below will not work with the latest Expo (SDK 46) and Hermes enabled (was working before when Hermes was disabled):
I think you are right @nandorojo this being a dependency-related and it might not be scoped to just using AnimatePresence. |
Oof Hermes is killing me here! Haha |
Having the same issue here, unfortunately 😢 .. and for me, trying to downgrade to 0.17.1, is not a possible workaround, because I'm already using the React 18 and with that the |
I'm experiencing the same issue as well and not using hermes, downgrading to 0.17.1 seems to work for me. I'm using:
With Moti 0.21.0 this does not work:
|
could you do me a favor and run |
Before:
After:
|
Okay so this must be it. Does the newest version work if you add a yarn resolution to framer 3.10.6? |
I've added a resolution to my package.json for framer-motion:
Then installed the latest Moti and ran Reverted back to 0.17.1, build and ran my app and then it works as intended. When using |
Hm, okay. Still a bit peculiar to me. Will try to figure it out when I can. |
Alright, I'm deeply investigating. I've spent hours diffing lock files. Here are some findings.
Here is what it looks like to install it: info Direct dependencies
└─ moti@0.18.0
info All dependencies
├─ @motify/components@0.18.0
├─ @motionone/animation@10.15.1
├─ @motionone/dom@10.12.0
├─ @motionone/easing@10.15.1
├─ @motionone/generators@10.15.1
├─ framer-motion@6.5.1
├─ moti@0.18.0
└─ popmotion@11.0.3 I ran a diff of all files from moti and went one-by-one to see what the cause could be (yes really). By pulling I tried changing So, I guess I have to refactor that back. This whole coding thing may not be for me lol |
Moti finally works with Hermes in version |
Is there an existing issue for this?
Current Behavior
MotiView stuck/freeze appearing animation when wrapped in AnimatedPresence with exitBeforeEnter prop. Patch from #195 and changes in #200 does not fix this bug.
Bug not exists in [email protected]
Steps To Reproduce
exitBeforeEnter
propVersions
Screenshots
Current Behavior:
2022-07-26.02.44.09.mov
Expected Behavior:
2022-07-26.02.48.49.mov
Reproduction
https://github.com/davidnum/motibug
The text was updated successfully, but these errors were encountered: