Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move up intermediate data downsampling in iEEG pipeline to load functions #157

Open
menoua opened this issue Apr 12, 2023 · 0 comments
Open

Move up intermediate data downsampling in iEEG pipeline to load functions #157

menoua opened this issue Apr 12, 2023 · 0 comments
Labels
performance Improve performance of already existing features

Comments

@menoua
Copy link
Member

menoua commented Apr 12, 2023

Expected Behavior

Currently, downsampling to the intermediate sampling rate happens immediately after loading the raw data files. If we can move this resampling to within (some of) the load functions, it will improve performance substantially. However, this is only useful when loading data one electrode at a time, because resampling has to be done on the full signal and not chunks of it, to maintain same precision as we have now. Currently, this does not seem to be the case for any of the load functions.
@menoua menoua added the performance Improve performance of already existing features label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Improve performance of already existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@menoua