Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required units for precipitation unclear #19

Closed
kvantricht opened this issue Oct 16, 2023 · 2 comments
Closed

Required units for precipitation unclear #19

kvantricht opened this issue Oct 16, 2023 · 2 comments

Comments

@kvantricht
Copy link
Contributor

Hi guys,

we're still working on setting up the first Presto encoder attempt from our side and we're facing issues with precipitation as an input. In general, I think there's a bit a of lack on documentation with regards to expected units for inputting data into Presto (like Sentinel-2 required to be in 1E4 scaling, Sentinel-1 required to be in decibels, etc.). I think we figured out most on our own, but for precipitation we're puzzled.
We see the ERA5_DIV_VALUES being 0.03 for precipitation. At the moment, we are feeding just the monthly sum in mm, but after normalization, the values in x explode due to this 0.03 factor. So what's the expected units?

https://github.com/nasaharvest/presto/blob/613265efac15c8c97a28d94fc2110a2d38e8a5e0/presto/dataops/pipelines/s1_s2_era5_srtm.py#L53:L55

Also note that the commented notebook where the values supposedly come from is inaccessible to us.

@gabrieltseng
Copy link
Collaborator

gabrieltseng commented Oct 16, 2023

Hi @kvantricht ,

We are using the ERA5 Land monthly averaged values - in this case, the unit for the precipitation (total_precipitation) is in metres.

I'll make a note in construct_single_presto_input making this more explicit.

@kvantricht
Copy link
Contributor Author

We're using ÀgERA5 instead which is derived ERA5 so I think fairly compatible. But precipitation is daily in mm which we accumulated to monthly values. Thanks for clarifying, I'll convert to m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants