Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POT files generation issues #366

Closed
Selenyhr opened this issue Nov 6, 2023 · 0 comments · Fixed by #367
Closed

POT files generation issues #366

Selenyhr opened this issue Nov 6, 2023 · 0 comments · Fixed by #367
Assignees
Labels
bug Something isn't working

Comments

@Selenyhr
Copy link
Contributor

Selenyhr commented Nov 6, 2023

Describe the bug
When generating POT files, there are two issues, one of which is due to Godot 4.1:

  • import lines are included in the POT file ;
  • quotes are not correctly escaped.

Affected version

  • Dialogue Manager version: v2.27.3
  • Godot version: v4.1.2.stable.arch_linux

To Reproduce
Use any file with a import line, and export POT files:

import "res://examples/dialogue.dialogue" as dialogue

Use any file where quotes are used within dialogues:

~ start
Nathan: This sentence contains "quotes."
=> END

Expected behavior
Import lines are not included in the POT file.

The other issue has been fixed in godotengine/godot#80058, however it may be nice to have some sort of forward-compatible fix for the quotes issue.

I will make a PR with a fix proposal. Could you try and make sure #365 will not include the new using syntax in the POT files please? :)

@Selenyhr Selenyhr added the bug Something isn't working label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants