Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoredMessage.Data as System.Buffers.Text #518

Closed
mtmk opened this issue Jun 18, 2024 · 0 comments · Fixed by #549
Closed

StoredMessage.Data as System.Buffers.Text #518

mtmk opened this issue Jun 18, 2024 · 0 comments · Fixed by #549
Assignees

Comments

@mtmk
Copy link
Collaborator

mtmk commented Jun 18, 2024

System.Buffers.Text has To/From for utf8 byte sequences and it looks like they work with netstandard20, adapting to such an approach longer term may help consolidate this code as well as lower the deserialization cost of KV and other stream reads in NET8 (as we can hold the base64 in UTF8 bytes rather than UTF16 string, maybe pool in future too? Not sure how easy it would be to do that part though...)

see also #513 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants