Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize styles in one file. #11

Open
aguycalled opened this issue Mar 15, 2022 · 3 comments
Open

Centralize styles in one file. #11

aguycalled opened this issue Mar 15, 2022 · 3 comments
Labels

Comments

@aguycalled
Copy link
Member

At the moment many components defines their own styles variable on its own file, creating duplicities.

Condense them in one file.

@tsejerome
Copy link
Contributor

Is there any examples of shared styles.

I believe that if our components are soft code enough, it is totally fine to have their own styles as they will not be relevant to each other, which means no duplication.

The only cases that might happen would be screens, layout and relatively big stuff. They might share styles.

@aguycalled
Copy link
Member Author

For example styles.box in DestinationComponent.tsx and SendTo.tsx, or styles.box in ImportWallet.tsx and OpenWallet.tsx. Those were just the first example I found but there must be more.

I'm not myself the best person in this universe in regard to styling, so I guess at some point we will have someone else having a look at the styles. Will be easier if they are all centralised.

@tsejerome
Copy link
Contributor

That means we should refactor the SendTo and ImportWallet as they are sharing the same box.
We should make a <Box/> instead of centralizing the style.

Another thing we could centralize other than layouts is colours, we currently use "grey", "gray", "white", "#fff", "#ffffff" which can be managed in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Open
Development

No branches or pull requests

3 participants