Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips on bar charts do not work in Firefox as of 3.12.3 #3854

Open
m-gallesio opened this issue Jul 24, 2024 · 5 comments
Open

Tooltips on bar charts do not work in Firefox as of 3.12.3 #3854

m-gallesio opened this issue Jul 24, 2024 · 5 comments

Comments

@m-gallesio
Copy link

I am using Firefox 128.0.2 on Windows 10.
Tooltips on bar charts do not work with billboard.js >= 3.12.3.
They do work correctly in version 3.12.2.

This can be seen in any documentation page (e.g. https://naver.github.io/billboard.js/demo/#Chart.BarChart)

This seems to be a Firefox-specific problem, since they work in Edge 126.0.2592.113.

@netil
Copy link
Member

netil commented Jul 24, 2024

@m-gallesio thanks for the report. I'll go over it.

@netil
Copy link
Member

netil commented Jul 26, 2024

@m-gallesio, tested on :

  • Windows 10 Pro(22H2),
  • FF v128.0, v128.0.2 and 129.0b8(beta)

As you can see from the below screenshot, it works showing tooltip correctly.
treemap-chrome

From the billboard.js 3.12.3 release, updated input type(mouse or touch) determination logic which possible the cause of your case. Check if you're using touch enabled devices.

@m-gallesio
Copy link
Author

My device is a regular laptop and should not be touch-enabled; I will have to look more into this.

@Mathnstein
Copy link

Mathnstein commented Aug 22, 2024

I can confirm the issue is that newer firefox and this interaction property are not working together correctly by default. Here is a solution with touch explicitly set to false:
interaction: {inputType: {mouse: true, touch: false}},

explicit_touch_false

@m-gallesio
Copy link
Author

The relevant commit seems to be this: f6201ad.
Its message seems wrong, there IS a difference in conditions in that the old version checked the media queries WITH parentheses while the new version does NOT.
I am decently sure parentheses should be included (see MDN as well as this line in the same file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants