Fix subscription flow for Event ID integrity #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This thing duplicates the hash calculation, so I'm trying to think of a way to not do that. Maybe create a new method, but I don't know. |
|
To avoid recalculating the hash, you should update the ID using the one generated by the checkSignature method. btw, I opened this issue due to the lack of feedback on my PR. Given the potential security risk, I strongly suggest reporting this as an issue, particularly if it is being deployed in a production environment by the community. good luck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a security issue by ensuring event IDs are verified, preventing a scenario where attackers could spoof event IDs to inject malicious events. It includes a fix and unit tests (TestEventIDIntegrity) for validation.