Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errant fields in CDS Sequencing template #434

Open
aclayton555 opened this issue Jun 26, 2024 · 9 comments
Open

Errant fields in CDS Sequencing template #434

aclayton555 opened this issue Jun 26, 2024 · 9 comments
Assignees
Labels

Comments

@aclayton555
Copy link
Contributor

aclayton555 commented Jun 26, 2024

Two attributes (cDNA Length and cDNA Offset) that were accidentally included in this initial version of the template. These are optional attributes and can be ignored by users currently, but we should remove these in the future. Likely due to a clash or issue with the DAG, as commented in #396

@aditigopalan
Copy link
Contributor

I think this was fixed here . Is there further work to be done on this?

@aclayton555
Copy link
Contributor Author

Cross check with #436

@PozhidayevaDarya
Copy link
Contributor

PozhidayevaDarya commented Jul 22, 2024

Cross check with #436

To the best of my knowledge, I don't think this issue co-occurs wtih 436. When I check the configs for the cds genomics mapping scripts it does not contain anything referencing CITE-seq and generally, CITE-seq was only implemented very recently.

Since that issue + PR is separate I think they can be moved forward independently from this one. @adamjtaylor

@aditigopalan
Copy link
Contributor

aditigopalan commented Jul 23, 2024

@PozhidayevaDarya @adamjtaylor I just generated a Multiplexed CITE-seq Level 1 manifest using dca staging and still see cDNA length and cDNA offset, is this still expected? I think I saw and fixed a similar issue in #417

Do we know where specifically these DAG loops are?

@aclayton555
Copy link
Contributor Author

24-7 close out: Okay if this rolls into 24-8 sprint.

@aclayton555
Copy link
Contributor Author

Check is these cDNA attributes are still appearing:

  • multiplex cite-seq L1
  • CDS seq template

@aditigopalan
Copy link
Contributor

aditigopalan commented Aug 13, 2024

Still seeing cDNA length and cDNA offset here, as optional fields. Is that expected?

@aclayton555
Copy link
Contributor Author

aclayton555 commented Sep 11, 2024

Check whether these are still in the CDS seq template. If they are, document this, and take no action, but be sure to communicate to contributors that they can ignore these two attributes.

Action: with every release, have latest blank templates auto-generated and push to a folder in GH @aclayton555 backlog a ticket for this. Doing this in MC2 - pull this over.

@aclayton555
Copy link
Contributor Author

Confirmed: these two attributes are still in the CDS seq template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants