Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make positional args optional #172

Open
ericwtodd opened this issue Jul 15, 2024 · 0 comments
Open

Make positional args optional #172

ericwtodd opened this issue Jul 15, 2024 · 0 comments

Comments

@ericwtodd
Copy link
Contributor

When using the NNsight class to wrap pre-existing pytorch modules (e.g. CLIP-ViT) where positional arguments are optional, users are currently forced to provide a positional argument (e.g. inputs).

Positional arguments to the NNsight forward should be made optional when the underlying model allows for it.

See discord discussion about this issue for a CLIP-VIT model: Discussion link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant