Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider PRing to main Rosé Pine cursors repo #3

Open
ThatOneCalculator opened this issue Mar 15, 2024 · 9 comments
Open

Consider PRing to main Rosé Pine cursors repo #3

ThatOneCalculator opened this issue Mar 15, 2024 · 9 comments

Comments

@ThatOneCalculator
Copy link

Hello! I'm the maintainer of the Rosé Pine cursors repo, and I'd love to bundle these with the main cursor builds! If not, I'd still love to get this repo into the Rosé Pine org so we can feature it on the website :)

@ndom91
Copy link
Owner

ndom91 commented Mar 17, 2024

Hey thanks for stopping by haha. Yeah so I'd be open to PR-ing it back into the main rose-pine cursor. How do you prefer we proceed?

Currenlty I only have dark-mode enabled here. I needed to take your "negative" svg's and apply the fg/bg colors for dark mode that are listed in the build process to generate ready-to-use dark mode SVG's (didn't want to use raster versions).

Anyway, I can run them through a find/replace and generate the light-mode ones as well

@ThatOneCalculator
Copy link
Author

Putting them in a hyprcursors folder in the main repo should be fine, and updating the readme to let people know there's a hyprcursor variant

@vaxerski
Copy link

maybe fixing the theme so that it actually works could be a good idea before that. Doesn't look like it was generated by util, as all compressed cursors are invalid.

@ndom91
Copy link
Owner

ndom91 commented Mar 24, 2024

Yeah someone else had problems with it on discord too 🤔

It wasn't generated with the util, but the cursors are just the meta files and svgs, I copied the structure and settings from an example you uploaded. Did you see what exactly was wrong with them?

@vaxerski
Copy link

yes, you didn't copy the structure.

image

left, rose pine, right, a theme made by the util

@ndom91
Copy link
Owner

ndom91 commented Mar 24, 2024

Ahh I didnt realize it included the dir too. Okay easy fix, thanks.

@ndom91
Copy link
Owner

ndom91 commented Mar 24, 2024

Alright, I put up a v0.3.2 (release with zip) and updated the flake + aur. Let me know if you still have issues.

What's another way to really confirm this works? I've got the env var set, a manual hyprctl setcursor returns ok and the flake puts the seemingly correct archives now to ~/.nix-profile/share/icons/rose-pine-hyprcursor/hyprcursor/xterm.hlc (for example).

Archive contents:

image

However, I can't see any change when, for exmaple, executing: hyprctl setcursor rose-pine-hyprcursor 32, 64, 100 or any other int 🤔

@troylusty
Copy link

This is now working as intended for me after the update to v0.3.2 installed via the AUR. I am even able to change its size using the command hyprctl setcursor rose-pine-hyprcursor 32 for example.

@vaxerski
Copy link

What's another way to really confirm this works? I've got the env var set, a manual hyprctl setcursor returns ok and the flake puts the seemingly correct archives now to ~/.nix-profile/share/icons/rose-pine-hyprcursor/hyprcursor/xterm.hlc (for example).

use hyprcursor-test from the hyprcursor repo. If you have multiple themes, you can force a theme by replacing nullptr in the constructor with "myTheme"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants