Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is yarn required for the build? #48

Open
andradei opened this issue Jul 26, 2024 · 3 comments
Open

Why is yarn required for the build? #48

andradei opened this issue Jul 26, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@andradei
Copy link

Is your feature request related to a problem? Please describe.
If user has node but not yarn the project can't be built.

Describe the solution you'd like
Don't have a hard dependency on yarn especially when node is the standard.
Check if yarn is installed before depending on it, otherwise use node.

@andradei
Copy link
Author

Also, as of today, the recommended way to install is by git cloning. If someone wants to integrate it with Mason so it can be installed via MasonInstall, they will have to check for the presence of yarn which is unnecessary.

@ndonfris
Copy link
Owner

ndonfris commented Jul 26, 2024

I get your point, and have already been trying to rely less on the use of yarn for distributing this project (prior to this issue). However, there are plenty of lsp projects using yarn, and I assume some of them are included in mason. For example: awk-lsp, typescript-language-server, etc...

As a neovim user, I'm familiar with the project Mason. I would love to have this lsp be supported there. Although, I'm not exactly sure what you're proposing. By node are you referring to npm?

Would removing the preinstall script resolve your issue?

I package this project on npm, and in earlier versions it did not seem to always install correctly for some users. That is why the recommended installation method is to clone this repo. Feel free to contribute to any fixes towards the projects' installation process!

Note

I've tried porting the project to pnpm in favor of yarn but had difficulties getting everything working.

@ndonfris ndonfris added enhancement New feature or request question Further information is requested labels Jul 26, 2024
@dsully
Copy link

dsully commented Aug 27, 2024

Having a GH release would help here as well in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants