Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.8 doesn't include log file changes #51

Closed
petertriho opened this issue Jul 27, 2024 · 3 comments
Closed

v1.0.8 doesn't include log file changes #51

petertriho opened this issue Jul 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@petertriho
Copy link
Contributor

Describe the bug
Looks like v1.0.8 was tagged incorrectly. It doesn't include the log file changes.
@petertriho petertriho added the bug Something isn't working label Jul 27, 2024
@petertriho petertriho changed the title Re-tag v1.0.8 v1.0.8 doesn't include log file changes Jul 27, 2024
@ndonfris
Copy link
Owner

Sorry about that! The tag has been updated on github.

I will republish v1.0.8 on npm, once the time limit is removed (within 24hrs).

@ndonfris
Copy link
Owner

Actually, here is a patched version v1.0.8-1:

Please let me know if there are any other issues!

@petertriho
Copy link
Contributor Author

Thanks, don't need to wait for npm since the nix builds pull from github.

Have the PR ready, just having some issues with the pr checks. Refactored the nix package to use mkDerivation + yarnConfigHook/yarnBuildHook instead of the old mkYarnPackage way. I also don't need the fish_wasm_file changes anymore but doesn't hurt just leaving it there.
NixOS/nixpkgs#330996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petertriho @ndonfris