Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for udp advertisement #31

Closed
BlockyTheDev opened this issue Jan 20, 2023 · 5 comments · Fixed by #87
Closed

Add support for udp advertisement #31

BlockyTheDev opened this issue Jan 20, 2023 · 5 comments · Fixed by #87
Labels
area::Receive Receive type::question Further information is requested

Comments

@BlockyTheDev
Copy link

My setup:

  • Android device (Android 10) connected through USB-C network adaptor to home network
  • Desktop PC without WLAN/Bluetooth (Windows 11) connected trough LAN cable to home network

It's already possible to send files from the Android device to the Windows system because the PC in the home network is shown in the device overview after pressing "Send" and selecting the file in the app. My problem is that it's not possible to receive files on Android with the same setup, because Windows doesn't showe the Android device.

If this can be implemented it would be great to see this feature in the future.

@ShortDevelopment
Copy link
Member

This is actually an interesting edge case!
The CDP protocol is laid out to do discovery over BluetoothLE Beacons to guarantee the devices are actually “nearby” and later switch to local network if possible (TransportUpgrade).

But there’s actually a discovery method that works via network only (no Bluetooth needed).
This one is used when you’re sending data to your PC.

Interestingly, it does not work with all PCs anymore (See #17)...

As I started working on my own implementation, I tried to do discovery via this network method, but Windows did not seem to respond, so it might actually be impossible to get this working, but it needs further investigation…

@BlockyTheDev Could you privately send me the following information via mail ([email protected])?

  • Content of %LocalAppData%\ConnectedDevicesPlatform\CDPGlobalSettings.cdp
  • Windows Specification (Win+R ms-settings:about)

@ShortDevelopment ShortDevelopment added type::question Further information is requested area::Receive Receive labels Jan 21, 2023
@BlockyTheDev
Copy link
Author

BlockyTheDev commented Jan 21, 2023

I have sent the information.

@ShortDevelopment
Copy link
Member

Great, thanks!
I'll have a look!

@ShortDevelopment ShortDevelopment changed the title Allow receiving files through LAN Add support for udp discovery Jan 29, 2023
@ShortDevelopment ShortDevelopment changed the title Add support for udp discovery Add support for udp advertisement Apr 22, 2023
@ShortDevelopment ShortDevelopment linked a pull request Apr 22, 2023 that will close this issue
@ShortDevelopment
Copy link
Member

@BlockyTheDev
This could now work in theory but Windows does not seem to advertise itself via udp.
But I could maybe create a patch for that...

@BlockyTheDev
Copy link
Author

BlockyTheDev commented Apr 29, 2023

But I could maybe create a patch for that...

Would be nice because at the moment the code change has "no use" for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area::Receive Receive type::question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants