Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't send large files #93

Closed
WXZhao7 opened this issue May 14, 2023 · 3 comments
Closed

Can't send large files #93

WXZhao7 opened this issue May 14, 2023 · 3 comments
Labels
area::Send Send type::bug Something isn't working

Comments

@WXZhao7
Copy link

WXZhao7 commented May 14, 2023

Wow, I found a treasure!
I installed the beta version, and everything worked except sending the file larger than ~250Mb. Here is my screen recording.

Screenrecorder-2023-05-14-15-05-04-165.mp4

Another confusing thing is the default receive path. The file stored at /storage/emulated/0/Android/media/de.shortdev.nearby_sharing_windows/Download/ not friendly for user. I guess this just a beta/test setting:)

@WXZhao7
Copy link
Author

WXZhao7 commented May 14, 2023

This version v1.3.3-beta not contain this issue.

@ShortDevelopment
Copy link
Member

That's likely doe to the custom send implementation (#21) I've added in v1.4.0.
I'll have a look; Thank you!

@ShortDevelopment ShortDevelopment added type::bug Something isn't working area::Send Send labels May 14, 2023
@ShortDevelopment ShortDevelopment changed the title app ver 1.41-beta broken sending file larger than about 250Mb Can't send large files May 14, 2023
@ShortDevelopment
Copy link
Member

ReadAsync might return before reading all bytes!

var buffer = new byte[contentStream.Length];
await contentStream.ReadAsync(buffer);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area::Send Send type::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants