Stale UI state on second login

[richiemccoll]

UPDATE: the PR which fixes this issue has been merged but it needs an expo SDK release to be available. See expo/expo#11503

I noticed some stale UI state after logging in with Google. This only happens after I log in and logout once. I was able to reproduce it on both iPhone and Android.

RPReplay_Final1613578363.MP4

Steps to Reproduce

• Login with Google & logout
• Login again with the same account

Expected

• User arrives on the Home screen

Actual

• User is stuck on the Auth screen

[simoneb]

it works for me

[richiemccoll]

@simoneb I've updated the PR description with a screen recording to illustrate the bug.

[simoneb]

I tried the steps but could not reproduce it. Let's sync on this tomorrow.

[n370]

Seem like we have company here. I've tried the changes seen at expo/expo#11714 (comment) and was able to get a consistent behavior where the login would work every other way.

There is a change coming that may get this one fixed for us: expo/expo#11503 (review).

[n370]

Yeah, I think https://github.com/expo/expo/pull/11503/files/d78341b54d53b089797cd67d6d33c6b391047348#diff-cddc4182283d931f6f145e203ed11d4b56c1cf74bd65e99d43459eb0a3e09f66 will fix the issue.

[simoneb]

Good catch!

[tiagoheliob]

Issued was fixed on this PR expo/expo#11503

[simoneb]

@tiagoheliob the issue was fixed in expo but did you check if we're using the expo version which includes that fix? Because I don't think we updated expo since a long time, hence the fix is not in the version we're using here. I'm reopening the issue, if you want to close it can you please double check this?

[simoneb]

I've also created #153 to upgrade expo to latest

[simoneb]

We need to verify whether this is still an issue after the application underwent further changes and after the expo upgrade, which may have got us the fix.

[salmanm]

Looks like this is fixed now. I tried logging in/out and all seemed fine on my phone