-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - Run schema validation during qhub init
#1267
Comments
Thanks for raising this @iameskild, I agree that having those checks as earlier as possible would be great. Though would we like those tests to be managed all by |
Once we get to a PR for this, we can update the naming convention that was missing for AWS (see comment) |
@iameskild @asmijafar20 is this being covered in your current PR? |
Yes, @trallard. |
In this PR, we are currently validating most of the inputs that are being passed in when running |
qhub init
qhub init
We are now performing validations during the init process. This was added during the large extension mechanism refactor. |
We are currently only running schema validation when
qhub render
is called. Let's move this sort of validation as early in the process as we can.Here is any example of the
qhub init
passing butqhub render
failing a validation check that should be caught earlier in the process, as part of this failed gh action:Related to #761
The text was updated successfully, but these errors were encountered: