Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Use human-readable cloud providers during guided init #1708

Closed
Tracked by #1478
pmeier opened this issue Apr 11, 2023 · 4 comments · Fixed by #2375
Closed
Tracked by #1478

[ENH] - Use human-readable cloud providers during guided init #1708

pmeier opened this issue Apr 11, 2023 · 4 comments · Fixed by #2375
Labels
good first issue Good for newcomers needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request

Comments

@pmeier
Copy link
Member

pmeier commented Apr 11, 2023

Feature description

Instead of using the short forms used for the machines, use the human readable versions for the cloud providers during --guided-init:

nebari/nebari/cli/init.py

Lines 331 to 335 in daecbcf

inputs.cloud_provider = questionary.select(
"Where would you like to deploy your Nebari cluster?",
choices=enum_to_list(ProviderEnum),
qmark=qmark,
).unsafe_ask()

nebari/nebari/schema.py

Lines 26 to 32 in daecbcf

class ProviderEnum(str, enum.Enum):
local = "local"
existing = "existing"
do = "do"
aws = "aws"
gcp = "gcp"
azure = "azure"

Value and/or benefit

I'm not super well-versed in the space yet, but "do" was not obvious to me. Compare

from nebari.cli.init import ProviderEnum, enum_to_list

for provider in enum_to_list(ProviderEnum):
    print(f"- {provider}")
- local
- existing
- do
- aws
- gcp
- azure

to a possible

- local
- existing
- DigitalOcean
- Amazon Web Services (AWS)
- Google Cloud Platform (GCP)
- Microsoft Azure

On top of being more readable, the latter also does not "leak" nebari internals to the user.

Anything else?

No response

@pmeier pmeier changed the title [ENH] - <title> [ENH] - Use human-readable cloud providers during guided init Apr 11, 2023
@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request needs: PR 📬 This item has been scoped and needs to be worked on labels Apr 12, 2023
@pavithraes
Copy link
Member

Thanks for reporting, added to the issue where we're gathering CLI improvements. :)

@pavithraes pavithraes added the good first issue Good for newcomers label Apr 22, 2023
@shashvatshah9
Copy link

Picking up this issue.

@pavithraes
Copy link
Member

Update: We initially expected the extension mechanism work to cover this, but this is still an issue.

@exitflynn
Copy link
Contributor

picking this up 🤠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants