Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - re-prompt user during guided init #1812

Open
pmeier opened this issue May 18, 2023 · 1 comment
Open

[ENH] - re-prompt user during guided init #1812

pmeier opened this issue May 18, 2023 · 1 comment
Labels
area: nebari-cli help wanted Extra attention is needed needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request

Comments

@pmeier
Copy link
Member

pmeier commented May 18, 2023

Feature description

While running nebari init --guided-init, one of the first things that one has to put in is a project name. There are some requirements listed, but if one puts in something that violates those, you are greeted by a ValueError and the process terminates.

At this point one has to start from scratch. Since we are already validating here, IMO it would be a lot better UX to just re-prompt the user. For example:

 🪴  Next, give your Nebari instance a project name. This name is what your Kubernetes cluster will be referred to as.

        The project name must adhere to the following requirements:
        - Letters from A to Z (upper and lower case) and numbers
        - Maximum accepted length of the name string is 16 characters
        - Should NOT start with the string `aws`


   What project name would you like to use? fancy!-project-name

Sorry, that name violates the requirements.

        The project name must adhere to the following requirements:
        - Letters from A to Z (upper and lower case) and numbers
        - Maximum accepted length of the name string is 16 characters
        - Should NOT start with the string `aws`

   What project name would you like to use?

Value and/or benefit

Less frustration.

Anything else?

No response

@pavithraes pavithraes added type: enhancement 💅🏼 New feature or request area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on help wanted Extra attention is needed labels May 22, 2023
@exitflynn
Copy link
Contributor

i think this could've been solved ever since regex validation was added right at the project name input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli help wanted Extra attention is needed needs: PR 📬 This item has been scoped and needs to be worked on type: enhancement 💅🏼 New feature or request
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants