Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Nebari init fails with --auth-provider custom #1934

Closed
Tracked by #1478
sblair-metrostar opened this issue Aug 23, 2023 · 4 comments · Fixed by #1994
Closed
Tracked by #1478

[BUG] - Nebari init fails with --auth-provider custom #1934

sblair-metrostar opened this issue Aug 23, 2023 · 4 comments · Fixed by #1994
Labels
area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on project: JATIC Work item needed for the JATIC project type: bug 🐛 Something isn't working
Milestone

Comments

@sblair-metrostar
Copy link
Contributor

Describe the bug

Running nebari init ... --auth-provider custom throws an error, "No registered Authentication type called custom". The --help content says this should be a valid option.

image

Expected behavior

Option 1. --auth-provider custom should work without error
Option 2. custom should be removed from the list of available options

OS and architecture in which you are running Nebari

Ubuntu Linux, x64

How to Reproduce the problem?

nebari init local --project-name foobar --auth-provider custom

image

Command output

No response

Versions and dependencies used.

Nebari: 2023.7.2.dev

Compute environment

None

Integrations

No response

Anything else?

No response

@sblair-metrostar sblair-metrostar added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Aug 23, 2023
@pavithraes pavithraes added area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Aug 25, 2023
@pavithraes pavithraes moved this from New 📬 to Scoped 📁 in 🪴 Nebari Project Management Aug 25, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Aug 28, 2023
@iameskild iameskild added the project: JATIC Work item needed for the JATIC project label Aug 28, 2023
@pavithraes pavithraes moved this from Scoped 📁 to Planned 💾 in 🪴 Nebari Project Management Aug 29, 2023
@iameskild
Copy link
Member

@costrouc @viniciusdc is it safe to remove custom as an option? I thought there were folks who still used it, perhaps I'm misremembering.

@iameskild
Copy link
Member

As I look at this more, I think the custom auth type can probably be removed. As for the attempt-fixes, we might be able to repurpose it as a way to by pass having the user accept the y for image upgrades, etc.

@sblair-metrostar
Copy link
Contributor Author

As I look at this more, I think the custom auth type can probably be removed. As for the attempt-fixes, we might be able to repurpose it as a way to by pass having the user accept the y for image upgrades, etc.

Agreed. According to this code, custom authenticators were deprecated some time ago. I'll work on a PR to remove that option from the CLI so we can close this out.

@iameskild
Copy link
Member

Thanks for following up @sblair-metrostar. I think we can move forward with removing this as an option in the CLI.

@pavithraes pavithraes moved this from TODO 📬 to In progress 🏗 in 🪴 Nebari Project Management Sep 11, 2023
@github-project-automation github-project-automation bot moved this from In progress 🏗 to Done 💪🏾 in 🪴 Nebari Project Management Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nebari-cli needs: PR 📬 This item has been scoped and needs to be worked on project: JATIC Work item needed for the JATIC project type: bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants