Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Nebari init with --repository-auto-provision --repository github.com fails on validation error #1936

Closed
Tracked by #1478
sblair-metrostar opened this issue Aug 23, 2023 · 0 comments · Fixed by #2012
Closed
Tracked by #1478

[BUG] - Nebari init with --repository-auto-provision --repository github.com fails on validation error #1936

sblair-metrostar opened this issue Aug 23, 2023 · 0 comments · Fixed by #2012
Labels
area: nebari-cli needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug project: JATIC Work item needed for the JATIC project type: bug 🐛 Something isn't working
Milestone
2023.10.1

Comments

@sblair-metrostar
Copy link
Contributor

Describe the bug

Using the repository/repository-auto-provision options with nebari init fails with contradictory validation errors

Expected behavior

  1. Some version of the command should work
  2. Consistent input validation and messaging for nebari init ... --repository-auto-provision

OS and architecture in which you are running Nebari

Ubuntu Linux, x64

How to Reproduce the problem?

nebari init local --project-name foobar --repository-auto-provision --repository github.com

... (stack trace)
ValueError: Repository to be auto-provisioned is not the full URL of a GitHub repo: github.com
nebari init local --project-name foobar --repository-auto-provision --repository https://github.com/MetroStar/foobar

image

Command output

No response

Versions and dependencies used.

Nebari: 2023.7.2.dev

Compute environment

None

Integrations

No response

Anything else?

Nothing in the nebari-config.yaml reflects the repository selection, so it's unclear what the use case is for --no-repository-auto-provision.
@sblair-metrostar sblair-metrostar added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Aug 23, 2023
@pavithraes pavithraes added needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug area: nebari-cli and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Aug 25, 2023
@pavithraes pavithraes mentioned this issue Aug 25, 2023
Open
@pavithraes pavithraes moved this from New 📬 to Scoped 📁 in 🪴 Nebari Project Management Aug 25, 2023
@iameskild iameskild added this to the Release 2023.9.1 milestone Aug 28, 2023
@iameskild iameskild added the project: JATIC Work item needed for the JATIC project label Aug 28, 2023
@pavithraes pavithraes moved this from Scoped 📁 to Planned 💾 in 🪴 Nebari Project Management Aug 29, 2023
@pavithraes pavithraes moved this from TODO 📬 to In progress 🏗 in 🪴 Nebari Project Management Sep 13, 2023
@sblair-metrostar sblair-metrostar mentioned this issue Sep 14, 2023
Merged
10 tasks
@iameskild iameskild moved this from In progress 🏗 to In review/QA 👀 in 🪴 Nebari Project Management Sep 18, 2023
@github-project-automation github-project-automation bot moved this from In review/QA 👀 to Done 💪🏾 in 🪴 Nebari Project Management Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: nebari-cli needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug project: JATIC Work item needed for the JATIC project type: bug 🐛 Something isn't working
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.10.1
Development

Successfully merging a pull request may close this issue.

cli init repo auto provision fix MetroStar/nebari
3 participants
@pavithraes @iameskild @sblair-metrostar