Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cluster_ca_certifiate typo in upgrade step #2597

Closed
Adam-D-Lewis opened this issue Jul 30, 2024 · 2 comments · Fixed by #2729
Closed

Handle cluster_ca_certifiate typo in upgrade step #2597

Adam-D-Lewis opened this issue Jul 30, 2024 · 2 comments · Fixed by #2729

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Jul 30, 2024

Context

Typos is added to the repo in #2568. This issue is to correct cluster_ca_certifiate typo in nebari/src/_nebari/stages/infrastructure/__init__.py which will require updating the nebari config during the nebari upgrade step.

Value and/or benefit

Fix a typo

Anything else?

No response

@Adam-D-Lewis Adam-D-Lewis added needs: triage 🚦 Someone needs to have a look at this issue and triage and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Jul 30, 2024
@blakerosenthal
Copy link
Contributor

I am noticing that when I generate the stages/ directory without fixing the typo, both stages/02-infrastructure/local/main.tf and stages/02-infrastructure/local/outputs.tf contain the correctly spelled string: cluster_ca_certificate. The typo'd string doesn't appear in my nebari-config.yaml. Is there an init option that will put this string in the config?

@Adam-D-Lewis
Copy link
Member Author

You're right. It looks like this pydantic model is only used as an output and won't show up in the nebari config file. I think you can just correct it without having to do anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants