Added support, cost, upgrade and keycloak commands.
#1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameskild
suggested changes
Sep 24, 2022
There was a problem hiding this comment.
Thanks again for this update @asmijafar20! I left a comment below regarding some changes that might need to be made. I'll let you decide how to proceed, if you have questions or concerns, feel free to reach out :)
qhub/keycloak.py
Outdated
|
|
||
| from .schema import verify | ||
| from .utils import load_yaml | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def do_keycloak(config_filename, *args): | ||
| def do_keycloak(config_filename, add_user, listusers): |
There was a problem hiding this comment.
This change is the reason the Kubernetes CI test is failing. Let's see if we can keep the original function while also making this work for our Typer CLI as well. This might just mean updating how we pass the above values to the function. A more robust solution might involve creating two subcommands, add-user and listusers.
There was a problem hiding this comment.
@viniciusdc and I wrote a code for the keycloak subcommand. But we couldn't make it possible because it's just tricky to do with typer. So later we changed the do_keycloak function, but CI will still fail because qhub entrypoint is using the previous do_keycloak function. Although I have pushed the new changes to the PR also added the subcommand code in the qhub/cli/keycloak.py (commented part).
|
iameskild
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
@asmijafar20 I was able to get the keycloak command to work with the existing CLI and also break it up into subcommands. I think there is still some clean up to do but we can tackle that later. Thanks for all your work on this :)
viniciusdc
added a commit
that referenced
this pull request
Oct 7, 2022
* Initial typer CLI implmentation * edit logic * Nebari cli: Add files _init.py and main.py (#1423) * Nebari cli: Add files _init.py and main.py * run pre-commit Co-authored-by: iameskild <[email protected]> * Order CLI commands * Nebari typer cli commands (#1432) * Nebari typer cli commands * add validate command * Change validate command * add precommit * Nebari Render Command (#1433) * Nebari Render Command * add render_template * Add dry-run * Updates to init * More work on init * Nebari deploy and destroy commands (#1436) * Nebari deploy and destroy commands * Add typer confirm to destroy command * Run pre-commit Co-authored-by: eskild <[email protected]> Co-authored-by: iameskild <[email protected]> * Add guided-init * Add deploy flags and change repository default value (#1441) * Nebari deploy and destroy commands * Add typer confirm to destroy command * Add deploy arguments and change repository default value * Add rendre design * Run pre-commit Co-authored-by: eskild <[email protected]> Co-authored-by: iameskild <[email protected]> * Nebari Typer CLI * Add pre-commit * Add disable_checks in deploy command * Combine guided-init and init, part 1 * Remove `dotenv` work. (#1472) * Remove Usage: dotenv [OPTIONS] COMMAND [ARGS] * Remove pathlib * guided-init clean up * Added `support`, `cost`, `upgrade` and `keycloak` commands. (#1468) * Add , , and commands. * Add pre-commit * Add pre-commit * Add pre-commit * Add rich print * Change do_keycloak function * Create two keycloak subcommands Co-authored-by: iameskild <[email protected]> Co-authored-by: eskild <[email protected]> * clean up * update help messages * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <[email protected]> * Changes from review, part 1 * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Pavithra Eswaramoorthy <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/_init.py Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/main.py Co-authored-by: Tania Allard <[email protected]> * Changes from review, part 2 * Update env, clean up * Changes from review, part 3 * Minor update * Changes based review, part 4 * more clean up * Add `version` options to Nebari CLI (#1476) * Add version Options to Nebari * Add pre-commit Co-authored-by: eskild <[email protected]> * Change colour from blue1 to green and spring_green to blue * Add suggested changes, Remove extra spaces * Add pre-commit * change kubernetes msg * Update CI to use new nebari cli entrypoint (#1480) * Update CI to use new nebari cli entrypoint * Add --disable-prompt to nebari init * Update name of keycloak subcommands * Reorder command * Update command * Minor update to test_e2e * Update hostname used for test_deployment * Another minor update to the tests_e2e * Add --disable-prompt to nebari destroy * use --disable-prompt in ci test * Update .github/workflows/kubernetes_test.yaml Co-authored-by: Vinicius D. Cerutti <[email protected]> * Update kubernetes_test.yaml * Update .github/workflows/kubernetes_test.yaml Co-authored-by: Tania Allard <[email protected]> * Update qhub/cli/main.py Co-authored-by: Tania Allard <[email protected]> * Fix yaml * Fix yaml again Co-authored-by: Vinicius D. Cerutti <[email protected]> Co-authored-by: Tania Allard <[email protected]> Co-authored-by: iameskild <[email protected]> Co-authored-by: eskild <[email protected]> Co-authored-by: Pavithra Eswaramoorthy <[email protected]> Co-authored-by: Tania Allard <[email protected]> Co-authored-by: Vinicius D. Cerutti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes introduced in this PR:
Types of changes
What types of changes does your PR introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Documentation
Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.