You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Couple of suggestions as it came across as a bit unintuitive when trying:
init on empty module list probably shouldn't be an error and cold be a warning, so you could have module without submodules, thus just nothing to do. Perhaps you could check if terraform init was run and then report an issue?
Error: terraform not initialized: no modules found in .terraform/modules directory: stat /home/marko/comns/aws-bedrock-kendra-s3-and-streamlit/infra/.terraform/modules/modules.json: no such file or directory
init should probably be idempotent operation and running it again shouldn't error out:
Error: .terraform.module.hcl file already exists
Confirming changes should probably accept y as well as yes
Is adding a new module part of upgrade operation? Maybe it's a future feature but currently doesn't seem there is a path for this and summary is reporting on this.
The text was updated successfully, but these errors were encountered:
for init on empty module list, I agree that a warning would be more appropriate than an error. Long term, if there is no modules.json file, I'd like to check and see if there are any external modules in the config. If there are, prompt the user to run terraform init. If not, let the user know that no external modules are found in the configuration with a warning.
for idempotency on init I guess, init could run check in the background and see if there's any divergence. If check returns changes, then init should prompt the user to run upgrade. Otherwise, it could signal to the use that no changes are required.
Agreed on accepting y as well as yes
Adding a new module or updating existing modules is all part of the upgrade operation. Do you have a suggestion for a different workflow?
One possibility is that new modules are added using init and changing existing modules happens with upgrade. Does that workflow make more sense?
Couple of suggestions as it came across as a bit unintuitive when trying:
init
on empty module list probably shouldn't be an error and cold be a warning, so you could have module without submodules, thus just nothing to do. Perhaps you could check ifterraform init
was run and then report an issue?init
should probably be idempotent operation and running it again shouldn't error out:y
as well asyes
upgrade
operation? Maybe it's a future feature but currently doesn't seem there is a path for this and summary is reporting on this.The text was updated successfully, but these errors were encountered: