Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Matrix construction does not match GitHub #769

Closed
catthehacker opened this issue Aug 8, 2021 · 0 comments · Fixed by #1200
Closed

Issue: Matrix construction does not match GitHub #769

catthehacker opened this issue Aug 8, 2021 · 0 comments · Fixed by #1200
Assignees
Labels
area/workflow Relating to workflow definitions kind/bug Something isn't working stale-exempt Exempt from stale

Comments

@catthehacker
Copy link
Member

Nothing which blocks this PR,
I think you aren't really aware of the behavior of the matrix include statement, (this is not introduced in this PR, but not fixed either)

Example Workflow run:
https://github.com/actions/runner/actions/runs/1082604590/workflow

This workflow demonstrates that includes needs to be handeled differently, if your matrix cross product is non empty and you have includes.

In my c# implementation of this,

  • Create the cross product (this seems to work in act with this PR)
  • apply excludes (this seems to work in act with this PR)
  • Merge the cross product if all member which are both in the cross product and include mapping are equal (added members or matrix entries to the cross product via include are not considered), otherwise do it like this code does.

Well this might be not perfect either, but this seems for me to be more like github actions.

Originally posted by @ChristopherHX in #763 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow Relating to workflow definitions kind/bug Something isn't working stale-exempt Exempt from stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant