-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoFix不管用 #82
Comments
Yeah, something got broken since like a week or so. |
Eslint doesn't do format. |
@chemzqm could you explain what you mean please? |
It only works with saved files, could be the problem you got. |
No, the files I'm working on are saved and it used to work until recently. I've had to add this to my vimrc to temporarily fix the behaviour: autocmd BufWritePre *.{js,jsx,ts,tsx} if exists(":CocAction") | :call CocAction('runCommand', 'eslint.executeAutofix') | sleep 100m | endif |
@chemzqm Could you, please, reopen the ticket. It is not about "formatting", it's about autoFixOnSave being broken. I've tried to bisect the issue but kind of failed. I tried downgrading eslint-coc while having latest coc and it doesn't work. I failed to downgrade coc deep enough to find a working combo. 😢 I've had typescript errors with Promise.resolve() demanding non-empty first argument. |
You have to create autocmd yourself if you want it always works neoclide/coc.nvim#2704. VSCode changed to use source code actions, but we don't have yet. If you have bug with it, you should provide output from eslint and the reproduce way. |
Do you plan on implementing source code actions? |
Aah, I see, you've already removed the CocConfig option As for source code actions, I actually switched to neovim+CoC because of them 😄. My VSCode freezes for about 10-20 seconds on "Getting source actions from eslint" when I save a typescript file |
我已经在coc-settings.json 添加了这个配置
可是我保存js 文件并不会自动格式化
The text was updated successfully, but these errors were encountered: