Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Lock the UI and present a modal during publish/discard #3743

Closed
4 tasks done
Tracked by #3742
grebaldi opened this issue Mar 13, 2024 · 0 comments · Fixed by #3759
Closed
4 tasks done
Tracked by #3742

FEATURE: Lock the UI and present a modal during publish/discard #3743

grebaldi opened this issue Mar 13, 2024 · 0 comments · Fixed by #3759
Assignees
Labels

Comments

@grebaldi
Copy link
Contributor

grebaldi commented Mar 13, 2024

Currently, after clicking on "Publish", "Publish all", "Discard" or "Discard all", the busy-state of the subsequent operation is only reflected right inside the Publishing menu button:
Peek 2024-03-13 10-59 - publishing

During the operation, the button is disabled and displays a loading indicator. The rest of the UI however remains operable - which is problematic, because editors shouldn't actually be able to edit content while their workspace is being published or discarded.

Success or failure of the operation is communicated to the user via a flash message.

@ahaeslich, @mficzel and I came up with the idea to replace both busy-state indication and flash message with modals that properly lock the UI during the entire operation. That modal context can then later be used as a stage for a dialog workflow for conflict resolution (#3742).

Acceptance criteria

Untitled-2024-03-13-1025 - publishing modals
(https://excalidraw.com/#room=98b84c8b6a652784af0a,oiqvD1exm6V8Hu4kttSGdg)

  • After clicking on "Publish", "Publish all", "Discard" or "Discard all", a modal appears that indicates the ongoing operation, and locks the UI thus preventing other operations
  • Once the Publish/Discard-operation is finished, the user is presented with a modal indicating success or failure of the operation
  • The busy-state of Publish/Discard-operations is no longer indicated inside the Publish-button

Nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant