Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian slug to Latin #696

Open
mamedovramil opened this issue Dec 12, 2021 · 6 comments · May be fixed by #695
Open

Russian slug to Latin #696

mamedovramil opened this issue Dec 12, 2021 · 6 comments · May be fixed by #695

Comments

@mamedovramil
Copy link

mamedovramil commented Dec 12, 2021

When creating a title in Russian, slug is also created in Russian, but the Latin alphabet is required.
Setting allow_unicode = False in the model Post.translations.slug helps, but there is no separate setting for that.

@fsbraun
Copy link
Contributor

fsbraun commented Dec 13, 2021

@mamedovramil Which version of djangocms-blog are you using. I believe in 1.2.3 the allow_unicode = True option is set for all post slugs.

Or are you talking about category slugs? I fear there the flag is missing in version 1.2.3.

@fsbraun
Copy link
Contributor

fsbraun commented Dec 13, 2021

PS: Just included the allow_unicode=True setting in PR #695 since it fits the PR's purpose. The PR needs to be approved, however.

@mamedovramil
Copy link
Author

@fsbraun sorry wrong, only setting allow_unicode = False helps to solve my problem. But I can't change that without editing blog model. My version is 1.2.3

--
When creating a title in Russian, slug is also created in Russian, but the Latin alphabet is required.
Setting allow_unicode = False in the model Post.translations.slug helps, but there is no separate setting for that.

@fsbraun
Copy link
Contributor

fsbraun commented Dec 13, 2021

@mamedovramil All right, I misunderstood. You get Cyrillic letters proposed for the slug but need latin letters, right? This means right now you have to manually change the slug to latin letters.

Can you check if category slugs behave as you propose?

If I get this right, you propose a feature to make configurable in the settings.

@mamedovramil
Copy link
Author

@fsbraun Correct. Category slug behave as I need.

@fsbraun fsbraun linked a pull request Dec 14, 2021 that will close this issue
5 tasks
@yakky
Copy link
Member

yakky commented Jul 28, 2022

Thanks a lot @fsbraun for taking care of this. Hopefully we will be able to merge support for this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants