Fix/add support for reversed version range #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this now. Please note that the docstring here should have been updated (but no worries I am doing that!): https://github.com/nerdvegas/rez/blob/master/src/rez/vendor/version/version.py#L723 I also noticed that while there are docs on version format in the wiki, there isn't for version range syntaxes. I will add that also, in a separate PR. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new pull request replacing #470 because i managed to completely fubar the original one. This is based off current master (which is 2.29.1)
Thanks a lot to @skral for fixing some issues in my original PR and for adding tests!
Sorry for the hassle, i shall take more care in the future.