refactor: rename ambiguous tx error

Revert "refactor: rename Cellbase -> CellBase"

This reverts commit 8de3ae7b07e0894bcdeb133b65cbbd1f4ce9af36.

verification/src/error.rs

@@ -114,10 +114,12 @@ pub enum DifficultyError {
 #[derive(Debug, PartialEq, Clone, Copy, Eq)]
 pub enum TransactionError {
     NullInput,
-    OutOfBound,
+    /// Occur output's bytes_len exceed capacity
+    CapacityOverflow,
     DuplicateInputs,
     Empty,
-    InvalidCapacity,
+    /// Sum of all outputs capacity exceed sum of all inputs in the transaction
+    OutputsSumOverflow,
     InvalidScript,
     ScriptFailure(ScriptError),
     InvalidSignature,

verification/src/tests/transaction_verifier.rs

@@ -45,7 +45,10 @@ pub fn test_capacity_outofbound() {
     };
     let verifier = CapacityVerifier::new(&rtx);
 
-    assert_eq!(verifier.verify().err(), Some(TransactionError::OutOfBound));
+    assert_eq!(
+        verifier.verify().err(),
+        Some(TransactionError::CapacityOverflow)
+    );
 }
 
 #[test]
@@ -69,7 +72,7 @@ pub fn test_capacity_invalid() {
 
     assert_eq!(
         verifier.verify().err(),
-        Some(TransactionError::InvalidCapacity)
+        Some(TransactionError::OutputsSumOverflow)
     );
 }
 

verification/src/transaction_verifier.rs

@@ -184,15 +184,15 @@ impl<'a> CapacityVerifier<'a> {
             .fold(0, |acc, output| acc + output.capacity);
 
         if inputs_total < outputs_total {
-            Err(TransactionError::InvalidCapacity)
+            Err(TransactionError::OutputsSumOverflow)
         } else if self
             .resolved_transaction
             .transaction
             .outputs()
             .iter()
             .any(|output| output.bytes_len() as Capacity > output.capacity)
         {
-            Err(TransactionError::OutOfBound)
+            Err(TransactionError::CapacityOverflow)
         } else {
             Ok(())
         }