Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust validation of channel announcement message #204

Open
contrun opened this issue Sep 26, 2024 · 0 comments
Open

More robust validation of channel announcement message #204

contrun opened this issue Sep 26, 2024 · 0 comments

Comments

@contrun
Copy link
Collaborator

contrun commented Sep 26, 2024

https://github.com/contrun/fiber/blob/eeb6ecfa2024dd6c82e3f5ed6a640cd19bf353bf/src/fiber/network.rs#L1745-L1774

While validating whether a channel announcement message is valid, we only checked if the script args is indeed the x only public key in the ChannelAnnouncement message and the ckb capacity is the same to the amount in ChannelAnnouncement. We should also check

  • We're actually using the funding contract
  • We capacity of udt is indeed the amount in the ChannelAnnouncement message
@contrun contrun changed the title Also check we're using the valid funding transaction contract while validating channel announcement message Check we're using the valid funding transaction contract while validating channel announcement message Sep 26, 2024
@contrun contrun changed the title Check we're using the valid funding transaction contract while validating channel announcement message More robust validation of channel announcement message Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant