You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While validating whether a channel announcement message is valid, we only checked if the script args is indeed the x only public key in the ChannelAnnouncement message and the ckb capacity is the same to the amount in ChannelAnnouncement. We should also check
We're actually using the funding contract
We capacity of udt is indeed the amount in the ChannelAnnouncement message
The text was updated successfully, but these errors were encountered:
contrun
changed the title
Also check we're using the valid funding transaction contract while validating channel announcement message
Check we're using the valid funding transaction contract while validating channel announcement message
Sep 26, 2024
contrun
changed the title
Check we're using the valid funding transaction contract while validating channel announcement message
More robust validation of channel announcement message
Sep 26, 2024
https://github.com/contrun/fiber/blob/eeb6ecfa2024dd6c82e3f5ed6a640cd19bf353bf/src/fiber/network.rs#L1745-L1774
While validating whether a channel announcement message is valid, we only checked if the script args is indeed the x only public key in the
ChannelAnnouncement
message and the ckb capacity is the same to the amount inChannelAnnouncement
. We should also checkChannelAnnouncement
messageThe text was updated successfully, but these errors were encountered: