debug intrinsic gas

godwokenrises · Jun 17, 2022 · 269b932 · 269b932
1 parent 371f656
commit 269b932
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/crates/generator/src/error.rs b/crates/generator/src/error.rs
@@ -1,3 +1,5 @@
+use std::borrow::Cow;
+
 use ckb_vm::Error as VMError;
 use gw_common::{error::Error as StateError, sparse_merkle_tree::error::Error as SMTError, H256};
 use gw_types::packed::Byte32;
@@ -155,8 +157,8 @@ pub enum TransactionError {
     NoCost,
     #[error("Nonce Overflow")]
     NonceOverflow,
-    #[error("Intrinsic gas")]
-    IntrinsicGas,
+    #[error("Intrinsic gas: {0}")]
+    IntrinsicGas(Cow<'static, str>),
 }
 
 impl From<VMError> for TransactionError {

diff --git a/crates/generator/src/verification/transaction.rs b/crates/generator/src/verification/transaction.rs
@@ -82,10 +82,22 @@ impl<'a, S: State + CodeStore> TransactionVerifier<'a, S> {
         }
         // Intrinsic Gas
         if let TypedRawTransaction::Polyjuice(tx) = typed_tx {
-            let p = tx.parser().ok_or(TransactionError::IntrinsicGas)?;
-            let intrinsic_gas = tx.intrinsic_gas().ok_or(TransactionError::IntrinsicGas)?;
+            let p = tx
+                .parser()
+                .ok_or_else(|| TransactionError::IntrinsicGas("parser".into()))?;
+            let intrinsic_gas = tx
+                .intrinsic_gas()
+                .ok_or_else(|| TransactionError::IntrinsicGas("intrinsic gas".into()))?;
             if p.gas() < intrinsic_gas {
-                return Err(TransactionError::IntrinsicGas.into());
+                return Err(TransactionError::IntrinsicGas(
+                    format!(
+                        "gas < intrinsic_gas, gas: {}, intrinsic gas: {}",
+                        p.gas(),
+                        intrinsic_gas
+                    )
+                    .into(),
+                )
+                .into());
             }
         }