Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation Dialogs #59

Closed
trelemar opened this issue Feb 28, 2017 · 5 comments
Closed

Confirmation Dialogs #59

trelemar opened this issue Feb 28, 2017 · 5 comments
Assignees
Labels
enhancement Improvement of existing feature or adding something new
Milestone

Comments

@trelemar
Copy link
Collaborator

trelemar commented Feb 28, 2017

Have a simple Y/N dialogue in the console if the user tries to delete a cart, or if the user makes a new cart when the current cart has unsaved changes.

@nesbox nesbox self-assigned this Feb 28, 2017
@nesbox nesbox added the enhancement Improvement of existing feature or adding something new label Feb 28, 2017
@nesbox
Copy link
Owner

nesbox commented Feb 28, 2017

I'll add confirmation text to the console:

> Are you sure to delete this file? [Y/N] : n
> Do you want to save chages you made? [Y/N] : n

@trelemar
Copy link
Collaborator Author

Great. I've never done it yet, but I'd hate to accidentally delete/override something I've been working on. Also, maybe if you try saving a cart where the same filename already exists it asks you.

@HomineLudens
Copy link
Collaborator

Would be nice also on application exit.

@trelemar
Copy link
Collaborator Author

Posted this in the chat room I'll put it here though:
To go alittle bit more in detail with the dialogs, say I launch tic, then on accident I type "save game" instead of "load game"
If I already had a "game.tic" it would be overridden with the new cart.

@nesbox
Copy link
Owner

nesbox commented Aug 21, 2017

WARNING dialog shows:

  • if you have unsaved changes and try to load/new/exit commands
  • if you try to delete a file using del command
  • if cartridge already exists and you try to overwrite it

works with mouse and keyboard

dialogs

done in .31

@nesbox nesbox closed this as completed Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or adding something new
Projects
None yet
Development

No branches or pull requests

3 participants