Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with @nestjs/common >= 9.0.0 #258

Closed
stouch opened this issue Jul 19, 2022 · 13 comments
Closed

Compatibility with @nestjs/common >= 9.0.0 #258

stouch opened this issue Jul 19, 2022 · 13 comments

Comments

@stouch
Copy link

stouch commented Jul 19, 2022

When using @nestjs/common >= 9.0.0 with npm 8, cannot install this lib without forcing --legacy-peer-deps

@stouch
Copy link
Author

stouch commented Jul 20, 2022

For v9 compatibility, we'll have to use another config format to fit with @nestjs/microservices and ioredis lib :

See nestjs/terminus#1288 (comment)

url seems not allowed anymore


Should we work on a PR @juandav or maybe you going to work on it soon ?

@stouch
Copy link
Author

stouch commented Aug 9, 2022

up 😇

Also seen that NestJS redis docs have changed a lot compared to the previous one (https://docs.nestjs.com/microservices/redis), I don't known how much this gonna affect this repo

@jonparkdev
Copy link

bump

@atassis
Copy link

atassis commented Mar 18, 2023

@juandav you have added support for the 9th version of nestjs, but didn't update the package in the npm.

@vadimoarturo
Copy link

vadimoarturo commented Mar 21, 2023

up

@srkimir
Copy link

srkimir commented Mar 22, 2023

+1

@pastean
Copy link

pastean commented Mar 24, 2023

is it safe to use by ignoring deps?

@dzcpy
Copy link

dzcpy commented Mar 25, 2023

Any updates? @jonparkdev @dantehemerson @cdiaz
Please publish the package to npm... Thanks!

@srkimir
Copy link

srkimir commented Apr 4, 2023

Can somebody please look into this

@srkimir
Copy link

srkimir commented Apr 9, 2023

Get rid of this package finally completely in favour of https://github.com/liaoliaots/nestjs-redis
which supports nest >=9.0.0
migration is quick and easy

@piyush-kacha
Copy link

piyush-kacha commented Apr 14, 2023

Can somebody please look into this

Code is already updated in master branch just somebody need to update in NPM.

@vadimoarturo
Copy link

Get rid of this package finally completely in favour of https://github.com/liaoliaots/nestjs-redis which supports nest >=9.0.0 migration is quick and easy

Will there be an update or can this one be used?

@juandav
Copy link
Member

juandav commented Dec 21, 2023

The library has already been updated to the latest version.

@juandav juandav closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants