Full support for numpy arrays and lists in Connect #1523
Labels
I: No breaking change
Previously written code will work as before, no one should note anything changing (aside the fix)
S: Normal
Handle this with default priority
T: Enhancement
New functionality, model or documentation
Following a discussion in #1429, I am adding an issue here regarding the support of lists and arrays in
Connect
.Is your feature request related to a problem? Please describe.
Currently, many forms of
Connect
are not supported, or require superfluous arguments:list
objects are not supportedsyn_spec
argumentDescribe the solution you'd like
All examples shown above should be accepted.
Describe alternatives you've considered
We are currently already checking the type of the input in
Connect
, thus, the solution to automatically convert toNodeCollection
if the ids are unique would only require a very minor overhead and no additional code complexity (just acheck_input_nodes
function that would replace the current test).I am not sure why
syn_spec
is currently required, but, to me, when input nodes are not unique, we should be able to switch to the "data connect" without any additional argument...The text was updated successfully, but these errors were encountered: