You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The work on #380 and #391 revealed that the build log generated on Travis should be improved:
Instead of relying on text or commands, introduce explicit marker lines with special format for mark the beginning and end of certain sections, e.g. ======= BEGIN VERA ======= and ======= END VERA =======. This will allow for much more robust parsing, even as the content of sections evolves.
If the statistical analysis has found problems, the final report may contain the entire diff result. Thus, the summary becomes very difficult to read. I suggest to keep it shorter, at least not include the full diff if it is longer than a few lines.
in build.sh may fail, presumably if Github cannot fullfill the request on time, leading to a
jq: error (at <stdin>:4): Cannot index string with string "filename"
In that case, the file_names variable in build.sh remains empty, no files are tested for formatting errors, and the build may pass even if the PR contained files with formatting errors. This should not happen: if the command filling file_names fails, the build should stop.
The text was updated successfully, but these errors were encountered:
The work on #380 and #391 revealed that the build log generated on Travis should be improved:
======= BEGIN VERA =======
and======= END VERA =======
. This will allow for much more robust parsing, even as the content of sections evolves.in build.sh may fail, presumably if Github cannot fullfill the request on time, leading to a
In that case, the
file_names
variable inbuild.sh
remains empty, no files are tested for formatting errors, and the build may pass even if the PR contained files with formatting errors. This should not happen: if the command fillingfile_names
fails, the build should stop.The text was updated successfully, but these errors were encountered: