Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and improve iaf_psc_*_multisynapse models #472

Closed
heplesser opened this issue Sep 6, 2016 · 1 comment · Fixed by #541
Closed

Review and improve iaf_psc_*_multisynapse models #472

heplesser opened this issue Sep 6, 2016 · 1 comment · Fixed by #541
Assignees
@heplesser @hakonsbm @stinebuu
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Model DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Milestone
NEST 2.12

Comments

@heplesser
Copy link
Contributor

heplesser commented Sep 6, 2016 •
edited
Loading

The iaf_psc_*_multisynapse models need review. Once #261 is merged, gif_psc_exp_multisynapse should be taken as reference for the review. Note in particular:

  • While all other neuron models require only that the refractory time is non-negative, iaf_psc_*_multisynapse require that the refractory time is at least one time step (see calibrate() method). This inconsistency should be removed and the multisynapse models should also accept zero refractory time.
  • handle(SpikeEvent&) uses a loop to find the spike buffer to deliver to. This can be selected by direct indexing using e.get_rport() - 1 as index.
@heplesser heplesser changed the title iaf_psc_*_multisynapse models prohibit zero refractory time Review and improve iaf_psc_*_multisynapse models Sep 6, 2016
@golosio golosio mentioned this issue Sep 13, 2016
Closed
@heplesser heplesser mentioned this issue Oct 13, 2016
Closed
@hakonsbm hakonsbm mentioned this issue Nov 2, 2016
Merged
@terhorstd terhorstd added ZC: Model DO NOT USE THIS LABEL I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. labels Nov 17, 2016
@heplesser heplesser added this to the NEST 2.12 milestone Nov 17, 2016
@heplesser
Copy link
Contributor Author

This will be fixed by #541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heplesser heplesser

@hakonsbm hakonsbm

@stinebuu stinebuu

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Model DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.12
Development

Successfully merging a pull request may close this issue.

Improve iaf_psc_alpha_multisynapse and iaf_psc_exp_multisynapse models hakonsbm/nest-simulator
4 participants
@heplesser @hakonsbm @terhorstd @stinebuu