Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing third rotation angle when rotating masks in 3D #899

Closed
stinebuu opened this issue Mar 7, 2018 · 1 comment
Closed

Missing third rotation angle when rotating masks in 3D #899

stinebuu opened this issue Mar 7, 2018 · 1 comment
Assignees
@stinebuu
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Comments

@stinebuu
Copy link
Contributor

stinebuu commented Mar 7, 2018

With PRs #664 and #845 we added the possibility to rotate the rectangle/box and elliptical/ellipsoidal topology masks. However, in 3D we are missing one of the rotation angles, namely rotation from the y-axis to the z-axis (the γ here). The third rotation angle should be added for completeness.
@heplesser heplesser added T: Enhancement New functionality, model or documentation ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 19, 2018
@stinebuu stinebuu removed ZC: Kernel DO NOT USE THIS LABEL ZP: Pending DO NOT USE THIS LABEL labels Apr 7, 2020
@heplesser
Copy link
Contributor

Closing since there is no user demand for this feature.

@jessica-mitchell jessica-mitchell moved this to Done in Kernel Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinebuu stinebuu

Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation
Projects
Kernel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heplesser @stinebuu