You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Error: @nestjs/graphql tried to access graphql-tools, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
#1162
Closed
andreialecu opened this issue
Sep 24, 2020
· 2 comments
[ ] Regression
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
@nestjs/graphql uses graphql-tools without listing it in its dependencies. It works in certain hoisting layouts because it hijacks it from apollo-server-core
This creates issues when using the package with Yarn's PnP resolution, and I assume also breaks the pnpm package manager.
Expected behavior
All imported packages should be listed in package.json.
What is the motivation / use case for changing the behavior?
It is a good practice to list all imported packages in package.json
Environment
Nest version: 7.7.0
The text was updated successfully, but these errors were encountered:
I'm submitting a...
Current behavior
@nestjs/graphql
usesgraphql-tools
without listing it in its dependencies. It works in certain hoisting layouts because it hijacks it fromapollo-server-core
This creates issues when using the package with Yarn's PnP resolution, and I assume also breaks the
pnpm
package manager.Expected behavior
All imported packages should be listed in package.json.
What is the motivation / use case for changing the behavior?
It is a good practice to list all imported packages in package.json
Environment
The text was updated successfully, but these errors were encountered: