We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I want to rewrite KafkaServer. The option is private.
https://github.com/nestjs/nest/blob/master/packages/microservices/server/server-kafka.ts#L45
import { KAFKA_DEFAULT_CLIENT, KAFKA_DEFAULT_GROUP, } from "@nestjs/microservices/constants"; import { KafkaOptions, ServerKafka } from "@nestjs/microservices"; import { KafkaConfig } from "@nestjs/microservices/external/kafka-options.interface"; export class AppServerKafka extends ServerKafka { constructor(protected readonly options: KafkaOptions["options"]) { super(options); const clientOptions = // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore this.getOptionsProp(this.options, "client") || ({} as KafkaConfig); this.clientId = // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore // eslint-disable-next-line @typescript-eslint/restrict-plus-operands (clientOptions.clientId || KAFKA_DEFAULT_CLIENT) + "_SERVER"; // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore // eslint-disable-next-line @typescript-eslint/restrict-plus-operands this.groupId = (consumerOptions.groupId || KAFKA_DEFAULT_GROUP) + "_SERVER"; } }
It should be protected.
constructor(private readonly options: KafkaOptions['options']) {
should be change to
constructor(protected readonly options: KafkaOptions['options']) {
Nest version: 7.5.1 For Tooling issues: - Node version: v12.19.0 - Platform: Mac Others:
The text was updated successfully, but these errors were encountered:
Would you like to create a PR for this issue?
Sorry, something went wrong.
Fixed in 7.5.0
No branches or pull requests
Bug Report
Current behavior
I want to rewrite KafkaServer. The option is private.
Input Code
https://github.com/nestjs/nest/blob/master/packages/microservices/server/server-kafka.ts#L45
Expected behavior
It should be protected.
Possible Solution
should be change to
Environment
The text was updated successfully, but these errors were encountered: