Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant check in signals.py #14119

Closed
arthanson opened this issue Oct 25, 2023 · 0 comments
Closed

Remove redundant check in signals.py #14119

arthanson opened this issue Oct 25, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@arthanson
Copy link
Collaborator

Proposed Changes

https://github.com/netbox-community/netbox/blob/develop/netbox/extras/signals.py#L66 if hasattr(instance, 'to_objectchange'): is redundant as it is already checked in line 45

Justification

Line is redundant as it is checked for earlier in the function.
@arthanson arthanson added the type: housekeeping Changes to the application which do not directly impact the end user label Oct 25, 2023
@jeremystretch jeremystretch self-assigned this Dec 21, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Dec 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arthanson @jeremystretch