Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "teamEnv" to "accountEnv" #1705

Closed
ehmicky opened this issue Jan 8, 2021 · 3 comments
Closed

Rename "teamEnv" to "accountEnv" #1705

ehmicky opened this issue Jan 8, 2021 · 3 comments
Assignees

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Jan 8, 2021

Background at netlify/build#2040 (comment)

We use both "account" and "team" terms in the Netlify Build repository.

It seems like an account is either a team or user.

https://github.com/netlify/open-api/blob/309feb2f40dc7b1003e94cfbda87b63e7bee4116/swagger.yml#L1233

We should rename those terms accordingly in the repository, including in open PRs (e.g. netlify/build#2040)

@ehmicky ehmicky self-assigned this Jan 8, 2021
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 8, 2021

From further inquiry, it seems like account is the same concept as team. "Account" being the name in the code and "team" the name in the UI and documentation.
If that is the case, it seems to me this monorepo should be good (since it uses the word "account"), but the CLI might need some renaming (since it uses the word "team", for example for team environment variables).

@ehmicky ehmicky changed the title Properly name accounts and teams Rename "teamEnv" to "accountEnv" Jan 8, 2021
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 8, 2021

After further checks, it appears the only action needed is to rename teamEnv to accountEnv in the CLI.

@ehmicky ehmicky assigned eduardoboucas and unassigned ehmicky Jan 8, 2021
@ehmicky ehmicky transferred this issue from netlify/build Jan 8, 2021
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 14, 2021

Done, thanks @eduardoboucas !

@ehmicky ehmicky closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants