-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split out detectors and templates, invite contributors #476
Comments
@calavera the approach i propose for this is to maintain two separate monorepos, one for detectors, one for templates. each monorepo contains all detectors and all templates (this is fine for our current scale). we will use pacote as it is far more active (but lower level).
this solves our re-releasing problem. it should also be performant and offline-ready because of pacote's caching (used by npm's cli itself) does this sound ok? it is the simplest approach and i wanted to address this before we launch. |
sounds good to me |
or maybe we should just use https://www.npmjs.com/package/gh-release-fetch 😅 |
tried to do this today, however gh-release-fetch requires asset artefacts, so i turned to the other two. both of them do NOT work offline as promised, which i am very disappointed about. wasted an hour or two. |
note that its useful here netlify/build#12 |
Closing in favor of #1495 |
(slack mention: https://netlify.slack.com/archives/CGW2Y6XPH/p1553102448110100)
we dont want to re-release the CLI and netliy dev plugin every time we add a new detector (or template).
we should use https://www.npmjs.com/package/live-plugin-manager or https://www.npmjs.com/package/pacote to make this scale.
however we should also have some consideration for offline dev experience.
The text was updated successfully, but these errors were encountered: