Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split out detectors and templates, invite contributors #476

Closed
swyxio opened this issue Mar 25, 2019 · 7 comments
Closed

split out detectors and templates, invite contributors #476

swyxio opened this issue Mar 25, 2019 · 7 comments
Labels

Comments

@swyxio
Copy link
Contributor

swyxio commented Mar 25, 2019

(slack mention: https://netlify.slack.com/archives/CGW2Y6XPH/p1553102448110100)

we dont want to re-release the CLI and netliy dev plugin every time we add a new detector (or template).

we should use https://www.npmjs.com/package/live-plugin-manager or https://www.npmjs.com/package/pacote to make this scale.

however we should also have some consideration for offline dev experience.

@swyxio
Copy link
Contributor Author

swyxio commented Apr 2, 2019

@calavera the approach i propose for this is to maintain two separate monorepos, one for detectors, one for templates. each monorepo contains all detectors and all templates (this is fine for our current scale).

we will use pacote as it is far more active (but lower level).

  • when netlify dev runs, we install the detector monorepo in the .netlify/detectors folder and require it
  • when netlify functions:create runs, we install the templates monorepo in the .netlify/function-templates folder and require it

this solves our re-releasing problem. it should also be performant and offline-ready because of pacote's caching (used by npm's cli itself)

does this sound ok? it is the simplest approach and i wanted to address this before we launch.

@calavera
Copy link
Contributor

does this sound ok? it is the simplest approach and i wanted to address this before we launch.

sounds good to me

@swyxio
Copy link
Contributor Author

swyxio commented Apr 16, 2019

or maybe we should just use https://www.npmjs.com/package/gh-release-fetch 😅

@swyxio swyxio changed the title split out detectors and templates split out detectors and templates, invite contributors Apr 17, 2019
@swyxio
Copy link
Contributor Author

swyxio commented May 4, 2019

tried to do this today, however gh-release-fetch requires asset artefacts, so i turned to the other two. both of them do NOT work offline as promised, which i am very disappointed about. wasted an hour or two.

@swyxio
Copy link
Contributor Author

swyxio commented Jul 8, 2019

note that its useful here netlify/build#12

@RaeesBhatti RaeesBhatti transferred this issue from netlify/netlify-dev-plugin Aug 12, 2019
@erezrokah
Copy link
Contributor

Closing in favor of #1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants