fix: correctly create edge function directory when running in custom cwd

[danez]

Summary

Fixes opennextjs/opennextjs-netlify#1400
Fixes netlify/pod-compute#150

The edge function dist path was incorrect when a custom working directory --cwd was supplied through the cli options. We were looking at /repo/path/.netlify/... instead of /repo/path/cwd/.netlify/...

Added a new test (which failed without the fix) and adjusted the other test to be more clear what failed. Just getting the uppercase/lowercase error, usually made me think this is some unimportant server/proxy conversation, but it actually means the edge function is not being loaded. Should be clearer now.

[github-actions]

📊 Benchmark results

Comparing with d074933

Package size: 222 MB

(no change)

^  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (a36bc16): 221 MB
• T-29 (a214002): 221 MB
• T-28 (9335721): 221 MB
• T-27 (e417c6e): 221 MB
• T-26 (62452c4): 221 MB
• T-25 (36945ec): 221 MB
• T-24 (e4a92e3): 221 MB
• T-23 (8d7d078): 227 MB
• T-22 (7ee7d2a): 227 MB
• T-21 (3d285ea): 227 MB
• T-20 (ab2c562): 227 MB
• T-19 (5d91429): 227 MB
• T-18 (8bdd73c): 227 MB
• T-17 (e00acbc): 227 MB
• T-16 (623fe51): 227 MB
• T-15 (65913b4): 221 MB
• T-14 (c766d51): 221 MB
• T-13 (419f447): 221 MB
• T-12 (0eb9d16): 222 MB
• T-11 (cfbb34d): 222 MB
• T-10 (5b112e3): 222 MB
• T-9 (e917f69): 222 MB
• T-8 (d522c2d): 222 MB
• T-7 (76ee52f): 222 MB
• T-6 (1f18298): 222 MB
• T-5 (11e3121): 222 MB
• T-4 (28dd027): 222 MB
• T-3 (684aa24): 222 MB
• T-2 (c6f3e85): 222 MB
• T-1 (d074933): 222 MB
• T (current commit): 222 MB

[eduardoboucas]

Great!

[eduardoboucas]

Not a blocker at all, but I'm curious about why you changed the test here. The previous test edge function was a bit more comprehensive, in that it was calling the origin and making a transformation, whereas the new one is just delivering a response.

[danez]

Isn't that what we are testing here? That the function was deployed correctly and runs correctly?

[danez]

I can revert it if you want, but I thought this is simpler and does exactly what we are trying to test here. And I guess/hope we have some tests somewhere that asserts that the edge internals work.

[eduardoboucas]

Isn't that what we are testing here? That the function was deployed correctly and runs correctly?

Yes, we're still covering that, and I understand that the functionality we're no longer testing here should be tested somewhere else. Still unclear to me why the change was needed, but that's okay.

[eduardoboucas]

I can revert it if you want, but I thought this is simpler and does exactly what we are trying to test here. And I guess/hope we have some tests somewhere that asserts that the edge internals work.

No need to revert.