fix: support npm modules + edge functions in monorepos #6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Nov 7, 2023
| #logAddedFunction(func) { | ||
| log(`${NETLIFYDEVLOG} ${chalk.green('Loaded')} edge function ${chalk.yellow(this.#getDisplayName(func.name))}`) | ||
| } | ||
| #logEvent(event, { buildError, functionName, warnings = [] }) { |
There was a problem hiding this comment.
I have centralised all log messages in this method, similar to what we're doing with the serverless functions registry.
eduardoboucas
commented
Nov 7, 2023
| } | ||
|
|
||
| /** | ||
| * @param {string} urlPath | ||
| * @param {string} method | ||
| */ | ||
| matchURLPath(urlPath, method) { | ||
| const declarations = this.#bundler.mergeDeclarations( |
There was a problem hiding this comment.
Instead of generating a manifest and routes on each request, we generate it every time we build the functions and then cache it in this.#manifest and this.#routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To make npm modules work in edge functions when in a monorepo setup, we need to use the repository root (and not the package root) as the base directory where we look for modules.
Closes https://linear.app/netlify/issue/COM-114/npm-modules-in-edge-functions-not-working-in-monorepo-setups.