Misleading error message when an invalid NETLIFY_AUTH_TOKEN is provided

[zetaraku]

Describe the bug

A confusing error message is shown when running netlify deploy with an invalid NETLIFY_AUTH_TOKEN:

»   Error: Site not found. Please rerun "netlify link"

I did some inspection and found out that a TextHTTPError: Unauthorized error is thrown from line 6 instead of expected line 11 in this file:

cli/src/utils/get-site.ts

Lines 4 to 18 in 73f4eb5

	export const getSiteByName = async (api, siteName) => {
	try {
	const sites = await api.listSites({ name: siteName, filter: 'all' })
	// @ts-expect-error TS(7006) FIXME: Parameter 'filteredSite' implicitly has an 'any' t... Remove this comment to see the full error message
	const siteFoundByName = sites.find((filteredSite) => filteredSite.name === siteName)
	if (!siteFoundByName) {
	throw Error
	}
	return siteFoundByName
	} catch {
	error('Site not found. Please rerun "netlify link"')
	}
	}

See also:

• https://answers.netlify.com/t/error-site-not-found-please-rerun-netlify-link/117207

Steps to reproduce

1. Run netlify deploy with a valid NETLIFY_SITE_ID and an invalid NETLIFY_AUTH_TOKEN.

Configuration

[build]
  command = "npm run build"
  publish = "./dist/"

Environment

System:
  OS: Windows 10 10.0.19045
  CPU: (8) x64 Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz
  Memory: 1.44 GB / 11.84 GB
Binaries:
  Node: 20.12.0 - C:\Program Files\nodejs\node.EXE      
  Yarn: 1.22.19 - ~\.yarn\bin\yarn.CMD
  npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
  pnpm: 8.15.5 - C:\Program Files\nodejs\pnpm.CMD