Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow any status code in builder functions #357

Merged
merged 3 commits into from
Aug 16, 2022
Merged

feat: Allow any status code in builder functions #357

merged 3 commits into from
Aug 16, 2022

Conversation

mraerino
Copy link
Member

@mraerino mraerino commented Aug 16, 2022 •
edited
Loading

🎉 Thanks for sending this pull request! 🎉

Which problem is this pull request solving?

There are requests to cache any status codes for builder functions.

List other issues or pull requests related to this problem

https://github.com/netlify/pillar-runtime/issues/443

Describe the solution you've chosen

We're removing the status check here, but our invocation proxy still has some checks in place.

Describe alternatives you've considered

n/a

Checklist

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@mraerino mraerino added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 16, 2022
@mraerino mraerino self-assigned this Aug 16, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Aug 16, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@mraerino mraerino changed the title All any status code in builder functions feat: All any status code in builder functions Aug 16, 2022
@mraerino mraerino changed the title feat: All any status code in builder functions feat: Allow any status code in builder functions Aug 16, 2022
@mraerino mraerino marked this pull request as ready for review August 16, 2022 11:49
@mraerino mraerino requested a review from a team August 16, 2022 11:49
@kodiakhq kodiakhq bot merged commit 0264c17 into main Aug 16, 2022
@kodiakhq kodiakhq bot deleted the feat/odb-all-codes branch August 16, 2022 14:19
@token-generator-app token-generator-app bot mentioned this pull request Aug 16, 2022
Merged
danez pushed a commit that referenced this pull request Oct 5, 2022
@token-generator-app
chore(main): release 1.2.0 (#358)
85fe91d 
🤖 I have created a release beep boop
1.2.0 (2022-08-16)
Features

Allow any status code in builder functions (#357) (0264c17)


This PR was generated with Release Please. See documentation.

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo paulo paulo approved these changes

@eduardoboucas eduardoboucas eduardoboucas approved these changes

Assignees

@mraerino mraerino

Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mraerino @paulo @eduardoboucas