feat: add new BackgroundHandler type #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is an interesting one. It's true that returning void is acceptable for a background function, but not for a synchronous function.
I wonder if in the same way we have a Handler type, we should have a specific type for background functions?
danez
force-pushed
the
function-handler-void
branch
from
4f88d47
to
91aa17b
Compare
danez
changed the title
github-actions
bot
added
the
type: feature
|
So I changed it to include one more type for background functions. |
danez
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](v1.2.0...v1.3.0) (2022-10-05) ### Features * add new BackgroundHandler type ([#364](#364)) ([b2d112b](b2d112b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes netlify/docs#2328
Promise<void>is a valid return type for a function.example:
I also added
tsdto test for the types.